Blocks: Treat RangeControl value as numeric #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2339 +/- ##
==========================================
+ Coverage 24.69% 24.74% +0.04%
==========================================
Files 152 152
Lines 4738 4745 +7
Branches 799 800 +1
==========================================
+ Hits 1170 1174 +4
- Misses 3014 3016 +2
- Partials 554 555 +1
Continue to review full report at Codecov.
|
ceyhun
pushed a commit
that referenced
this pull request
Jun 17, 2020
…op_merge 1.29.0 master to develop merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to update
RangeControlin line with other block inspector controls to pass through the updated value ononChangeinstead of the original event, and in doing so treat the updated value as numeric. SinceRangeControlis used for assigning numeric values, it was easy to overlook and assigningevent.target.valuewould assign a string value, resulting in warnings:parser.js:140 Expected attribute "columns" of type number for block type "core/gallery" but received string.See: #1905
Testing instructions:
Verify there are no regressions or console warnings in changing...
Ensure unit tests pass: